Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cpe23 link in ExternalIdentifierType #806

Merged
merged 9 commits into from
Jul 30, 2024
Merged

Update cpe23 link in ExternalIdentifierType #806

merged 9 commits into from
Jul 30, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Jul 25, 2024 •
edited
Loading

  • Make cpe23 URL matched with one in the References chapter (see Update References chapter spdx-spec#1006 )
  • Add full names to some entries.
    • For example, swid here is specifically a concise SWID one according to the ref. So add "Concise Software Identification tag" to the description.
  • Update obsoleted ref
    • swid ref to a pre-RFC Internet Draft that expired on 8 Sep 2022, updated to RFC 9393 which replace it
  • Make all URLs clickable. Also add text labels to bare URLs, as required by OMG/ISO standard doc

bact added 3 commits July 25, 2024 11:45
@bact
Update cpe23 link
ebfc8c2 
Make URL matched with one in the References chapter

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Merge branch 'main' into update-urls-ExternalIdentifierType
42c4e47 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Add names
d994663 
`swid` here is specifically a concise SWID one according to the ref

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact mentioned this pull request Jul 25, 2024
Merged
zvr
zvr requested changes Jul 26, 2024
View reviewed changes
Copy link
Member

@zvr zvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links should not be visible (I only did a couple)

bact and others added 2 commits July 26, 2024 11:28
@bact @zvr
Apply suggestions from code review
1f484d0 
Co-authored-by: Alexios Zavras (zvr) <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Make links not visible
69484bf 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact requested a review from zvr July 26, 2024 10:39
@bact
Copy link
Collaborator Author

bact commented Jul 26, 2024

Links should not be visible (I only did a couple)

Thanks. I have made all of them invisible now.

This was referenced Jul 26, 2024
Closed
Closed
@bact
doesn't -> does not
375c7bf 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
goneall
goneall approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bact bact mentioned this pull request Jul 30, 2024
Merged
@zvr zvr merged commit ff3d857 into spdx:main Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvr zvr zvr approved these changes

@goneall goneall goneall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bact @zvr @goneall