-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serialization info + NamespaceMap info #1016
Merged
zvr
merged 10 commits into
spdx:development/v3.0.1
from
bact:add-NamespaceMap-info-to-Serialization-page
Aug 8, 2024
Merged
Add serialization info + NamespaceMap info #1016
zvr
merged 10 commits into
spdx:development/v3.0.1
from
bact:add-NamespaceMap-info-to-Serialization-page
Aug 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use content from https://github.com/spdx/spdx-3-model/blob/main/serialization/README.md and revise to use standard terms like "may", "shall". Signed-off-by: Arthit Suriyawongkul <[email protected]>
This was referenced Jul 31, 2024
Signed-off-by: Arthit Suriyawongkul <[email protected]>
goneall
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @bact
Signed-off-by: Arthit Suriyawongkul <[email protected]>
JPEWdev
approved these changes
Aug 6, 2024
maxhbr
reviewed
Aug 6, 2024
maxhbr
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good up to question
Thank you @maxhbr Co-authored-by: Maximilian Huber <[email protected]> Signed-off-by: Arthit Suriyawongkul <[email protected]>
zvr
reviewed
Aug 7, 2024
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]> Co-Authored-By: Alexios Zavras (zvr) <[email protected]>
zvr
requested changes
Aug 8, 2024
Co-authored-by: Alexios Zavras (zvr) <[email protected]> Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
zvr
approved these changes
Aug 8, 2024
We can now make NamespaceMap to refer to https://spdx.github.io/spdx-spec/v3.0.1/serializations/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR do?
Background
What this PR still missing?
serializedInArtifact
a correct relationship type for this paragraph: