Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strikethrough and typo in relationshipType translation table (Annex A) #1017

Closed

Conversation

bact
Copy link
Collaborator

@bact bact commented Jul 31, 2024

  • Remove strikethrough formatting
  • Fix typo: hasPrequisite -> hasPrerequisite

Questions

  1. Does this table complete?
    • A sentence before the table said:

      Relationship migration is being worked out in the relationships spreadsheet. Once completed, the following table will reflect the translation for relationship types from SPDX 2.3 to SPDX 3.0:

  2. What does "lifecycle scope" in the last column mean?
    • Other values in this column are types in LifecycleScopeType (for example, "build", "build, runtime", "test") or a string stating "various LifecycleScopeType".
    • Should this "lifecycle scope" string be replaced by "various LifecycleScopeType"?
  3. The 3rd column ("Swap to and from?") probably not complete?
    • For example, 2.3 DATA_FILE_OF and 3.0 hasDataFile they are swapped in direction. But there's no "Y" marked in their column.
    • A (is a) DATA_FILE_OF B
    • B hasDataFile A

- Replace the non-native-supported strikethrough with native-support italic formatting
- Fix typo: hasPrequisite -> hasPrerequisite

Signed-off-by: Arthit Suriyawongkul <[email protected]>
Copy link
Member

@zvr zvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a point in changing the typography for relationship names, since the second column clearly says they were removed.

@zvr zvr added this to the 3.0.1 milestone Aug 4, 2024
@bact
Copy link
Collaborator Author

bact commented Aug 5, 2024

Close this one as it will be better covered by #1019

@bact bact closed this Aug 5, 2024
@bact bact deleted the remove-strikethrough-format branch August 5, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants