Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove numbering, set list of files #1044

Merged
merged 5 commits into from
Aug 11, 2024
Merged

Remove numbering, set list of files #1044

merged 5 commits into from
Aug 11, 2024

Conversation

zvr
Copy link
Member

@zvr zvr commented Aug 11, 2024

  • Removes numbering from chapters/sections in main spec
  • Does the same for annexes (removing unused files)
  • Updates mkdocs configuration with chapters and annexes

Also renames some files, changes titles to consistent casing, etc.

Closes #1023
Closes #1040
Closes #1041

@zvr zvr mentioned this pull request Aug 11, 2024
Closed
@zvr zvr requested review from bact, goneall and kestewart August 11, 2024 16:05
@zvr zvr added this to the 3.0.1 milestone Aug 11, 2024
bact
bact requested changes Aug 11, 2024
View reviewed changes
Copy link
Collaborator

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add back HTML anchors in SPDX Lite annex, as they are also appeared in other files.

bact
bact reviewed Aug 11, 2024
View reviewed changes
kestewart
kestewart reviewed Aug 11, 2024
View reviewed changes
@goneall @kestewart
Remove the TODO
d60476e 
Co-authored-by: Kate Stewart <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
kestewart
kestewart approved these changes Aug 11, 2024
View reviewed changes
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed this in call about anchors, and don't think this will impact pdf, so going ahead and merging.

goneall
goneall approved these changes Aug 11, 2024
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bobmartin3000
bobmartin3000 approved these changes Aug 11, 2024
View reviewed changes
Copy link

@bobmartin3000 bobmartin3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bact
bact approved these changes Aug 11, 2024
View reviewed changes
Copy link
Collaborator

@bact bact left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - Will do the filenames later

@goneall goneall merged commit d511e8c into spdx:development/v3.0.1 Aug 11, 2024
3 checks passed
This was referenced Aug 11, 2024
Merged
Merged
@zvr zvr deleted the no-chap-nums branch August 12, 2024 06:29
@bact bact mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bact bact bact approved these changes

@goneall goneall goneall approved these changes

@kestewart kestewart kestewart approved these changes

@bobmartin3000 bobmartin3000 bobmartin3000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.1
5 participants
@zvr @bact @goneall @kestewart @bobmartin3000