Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update References #1050

Merged
merged 8 commits into from
Aug 11, 2024
Merged

Update References #1050

merged 8 commits into from
Aug 11, 2024

Conversation

zvr
Copy link
Member

@zvr zvr commented Aug 11, 2024

This adds a number of resources referenced in the spec chapters and model.

Closes #1048

Signed-off-by: Alexios Zavras [email protected]

Signed-off-by: Alexios Zavras <[email protected]>
@zvr zvr requested review from bact, goneall and kestewart August 11, 2024 19:14
@zvr zvr added this to the 3.0.1 milestone Aug 11, 2024
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider applying the fixes to help standardize the references.

@zvr
Copy link
Member Author

zvr commented Aug 11, 2024

I don't mind adding "CPE" and "CVSS", but then we won't be using the official titles any more...

Copy link
Collaborator

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this.

@bobmartin3000
Copy link

I'm good with this approach even though the titles are changed.

Copy link

@bobmartin3000 bobmartin3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

goneall and others added 5 commits August 11, 2024 13:43
Co-authored-by: Kate Stewart <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Co-authored-by: Kate Stewart <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Co-authored-by: Kate Stewart <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Co-authored-by: Kate Stewart <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Co-authored-by: Kate Stewart <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks!

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bact
Copy link
Collaborator

bact commented Aug 11, 2024

@goneall The validate failed from an issue unrelated to this PR.
Noted here spdx/spdx-3-model#837 - to be fixed in another PR.

Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider applying the fixes to help standardize the references.

@goneall goneall merged commit 9dc48a3 into spdx:development/v3.0.1 Aug 11, 2024
2 checks passed
@zvr zvr deleted the fix-references branch August 12, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update References chapter
5 participants