-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON-LD context and validation info to Serialization chapter #1059
Conversation
Use info from - https://github.com/spdx/spdx-3-model/blob/main/serialization/README.md - https://github.com/spdx/spdx-3-model/blob/main/serialization/jsonld.md Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good - one minor suggestion on use of caps, but I'll approve. If @zvr and/or @kestewart approve of the current state, please feel free to merge.
I'll need to add the context, ontology, and schema to the spdx.org website for the links in this PR to be live.
Signed-off-by: Arthit Suriyawongkul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Keep track with #1060 |
Use info from
This will resolve #998
Please also check the 3 URLs used in the content if they are the preferred location:
Note: Those 3.0.1 URLs are based on 3.0.0 URLs:
spdx-spec/examples/jsonld/package_sbom.json
Line 2 in b2f7464
spdx-spec/bin/check-examples.sh
Line 60 in b2f7464
spdx-spec/docs/annexes/rdf-model.md
Line 7 in b2f7464
spdx-spec/bin/check-examples.sh
Lines 20 to 22 in b2f7464
spdx-spec/bin/check-examples.sh
Lines 15 to 17 in b2f7464