-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Terms and definitions" back to navigation bar #1064
Merged
goneall
merged 4 commits into
spdx:development/v3.0.1
from
bact:add-back-terms-and-definitions
Aug 17, 2024
Merged
Add "Terms and definitions" back to navigation bar #1064
goneall
merged 4 commits into
spdx:development/v3.0.1
from
bact:add-back-terms-and-definitions
Aug 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bobmartin3000 please kindly review. |
We don't have anything to put in this chapter, why include it? |
We have the reference to iso terms and we will need to create specific terms and definitions before the OMG meeting since itbb be is a required section. With the section there I can say we are working on the terms and definitions. Without it there we will be told it is required and have to do it any ways. By putting a placeholder of iso references we show we know we need it.
Bob
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Alexios Zavras (zvr) ***@***.***>
Sent: Tuesday, August 13, 2024 1:51:45 AM
To: spdx/spdx-spec ***@***.***>
Cc: Robert A Martin ***@***.***>; Mention ***@***.***>
Subject: [EXT] Re: [spdx/spdx-spec] Add "Terms and definitions" back to navigation bar (PR #1064)
We don't have anything to put in this chapter, why include it? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned. Message ID: <spdx/spdx-spec/pull/1064/c2285389118@ github. com>
We don't have anything to put in this chapter, why include it?
—
Reply to this email directly, view it on GitHub<#1064 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUYBD7FDYTUB3T5RZJ354WLZRGNHDAVCNFSM6AAAAABMNNLFLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBVGM4DSMJRHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
bobmartin3000
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kestewart
approved these changes
Aug 16, 2024
goneall
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Terms and definitions" was previously available, add it back per @bobmartin3000 request (email 2024-08-12/13)
Also removing the "Todo" line from the content.