Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Terms and definitions" back to navigation bar #1064

Merged
merged 4 commits into from
Aug 17, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Aug 13, 2024

"Terms and definitions" was previously available, add it back per @bobmartin3000 request (email 2024-08-12/13)

Also removing the "Todo" line from the content.

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact added this to the 3.0.1 milestone Aug 13, 2024
@bact
Copy link
Collaborator Author

bact commented Aug 13, 2024

@bobmartin3000 please kindly review.

@zvr
Copy link
Member

zvr commented Aug 13, 2024

We don't have anything to put in this chapter, why include it?

@bobmartin3000
Copy link

bobmartin3000 commented Aug 13, 2024 via email

Copy link

@bobmartin3000 bobmartin3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bact bact requested review from zvr, goneall and kestewart August 13, 2024 11:05
@goneall goneall merged commit 63f1111 into spdx:development/v3.0.1 Aug 17, 2024
2 checks passed
@bact bact deleted the add-back-terms-and-definitions branch August 17, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants