Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in 3.0.1 spec #1087

Merged
merged 8 commits into from
Aug 27, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Aug 22, 2024

SPDX license expressions annex

Fix typo in SPDX license expressions annex as reported by @brokenjpl

Conformance chapter

Fix typos in Conformance chapter as reported by @vargenau

Symbols chapter

Fix typos in the Symbols chapter as reported by @vargenau + additional typos

bact and others added 3 commits August 22, 2024 23:03
Fix typos as reported by @vargenau + additional typos

Signed-off-by: Arthit Suriyawongkul <[email protected]>
Co-Authored-By: Marc-Etienne Vargenau <[email protected]>
As reported by @brokenjpl

Signed-off-by: Arthit Suriyawongkul <[email protected]>
Co-Authored-By: Jean-Pierre Levac <[email protected]>
As reported by @vargenau

Signed-off-by: Arthit Suriyawongkul <[email protected]>
Co-Authored-By: Marc-Etienne Vargenau <[email protected]>
As reported by @vargenau

Signed-off-by: Arthit Suriyawongkul <[email protected]>
Co-Authored-By: Marc-Etienne Vargenau <[email protected]>
@bact bact mentioned this pull request Aug 22, 2024
@bact bact requested review from zvr, goneall and kestewart August 22, 2024 16:04
@bact
Copy link
Collaborator Author

bact commented Aug 22, 2024

@bobmartin3000 please kindly review.

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @bact

Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of tweaks, after those are sorted, should be good to merge.

bact and others added 3 commits August 23, 2024 16:39
Co-authored-by: Kate Stewart <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Co-authored-by: Kate Stewart <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact requested a review from kestewart August 23, 2024 16:28
@goneall goneall merged commit 0ecb957 into spdx:development/v3.0.1 Aug 27, 2024
3 checks passed
@bact bact deleted the fix-typos-reported-by-vargenau branch August 28, 2024 11:08
@bact bact added the typo Typos, minor spelling errors, or minor incorrect word usage label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
publishing typo Typos, minor spelling errors, or minor incorrect word usage
Projects
None yet
6 participants