Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base IRI in annotations.ttl to 3.0.1 #1096

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Aug 27, 2024

Current CI, copies serialization/jsonld/annotations.ttl from development/v3.0.1 branch
to docs/rdf/jsonld-annotations.ttl in gh-pages branch,
which make it available at https://spdx.github.io/spdx-spec/v3.0.1/rdf/jsonld-annotations.ttl

But jsonld-annotations.ttl there is still using https://spdx.org/rdf/3.0.0/terms/ in its content.

This PR update https://spdx.org/rdf/3.0.0/terms/ to https://spdx.org/rdf/3.0.1/terms/

@bact bact added this to the 3.0.1 milestone Aug 27, 2024
@bact bact requested review from goneall, maxhbr, kestewart and zvr August 28, 2024 07:14
@bact
Copy link
Collaborator Author

bact commented Aug 28, 2024

@JPEWdev please kindly correct me if I'm wrong. Thank you.

@bact
Copy link
Collaborator Author

bact commented Sep 6, 2024

Since the 3.0.1 CI is already up, we need this the change from this PR to be applied.

Currently https://spdx.github.io/spdx-spec/v3.0.1/rdf/jsonld-annotations.ttl has @base <https://spdx.org/rdf/3.0.0/terms/> ., it needs to be updated.

ping @goneall @zvr

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall goneall merged commit 66e60cd into spdx:development/v3.0.1 Sep 10, 2024
2 checks passed
@bact bact deleted the update-annotation-301 branch September 10, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants