Update examples validation to v3.0.1 #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also consolidated code to use the existing check_schema and check_model functions - Update relevant URLs to 3.0.1 ones Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
|
@JPEWdev does this look ok? Thank you for your help. |
Signed-off-by: Arthit Suriyawongkul <[email protected]>
|
All necessary 3.0.1 URLs are ready. We can now go ahead with this PR. |
kestewart
approved these changes
Sep 10, 2024
maxhbr
approved these changes
Sep 10, 2024
| done | ||
| fi | ||
|
|
||
| TEMP=$(mktemp -d) |
There was a problem hiding this comment.
temporary directory is not cleaned up
Co-authored-by: Maximilian Huber <[email protected]> Signed-off-by: Arthit Suriyawongkul <[email protected]>
Co-authored-by: Maximilian Huber <[email protected]> Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
maxhbr
approved these changes
Sep 10, 2024
|
Thank you @maxhbr, I also use your suggestions to update the similar validation script in spdx/using. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This will not working until the first part of #1108 (the 3.0.1 part) got resolved(setting up https://spdx.org/rdf/3.0.1/spdx-model.ttl, etc)
3.0.1 part of #1108 is already applied. These URLs are ready:
After reviews, we can merge this.
This PR will resolve #1049