Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI update for spec-parser 2.5.0 #1113

Merged
merged 11 commits into from
Sep 10, 2024
Merged

CI update for spec-parser 2.5.0 #1113

merged 11 commits into from
Sep 10, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Sep 6, 2024 •
edited
Loading

  • Update model file list name to match spec-parser's new filename (mkdocs-files.yml -> model-files.yml)
  • Update RDF and MkDocs Markdown directories to match spec-parser's new output directory structure
  • Install pandoc (required by spec-parser for Tex files generation)
  • Install an empty "pandoc" script, to bypass pandoc-requirement (pandoc is for Tex generation, which is not necessary in the CI)

This PR will fix #1066 and fix #1112

bact added 4 commits September 6, 2024 17:09
@bact
Update dir and filename for spec-parser 2.5.0
0ad9794 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Rename PARSER_OUT variables to group them together
d13749b 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Update comments
07d7573 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Install pandoc
593047a 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact requested review from zvr, goneall and licquia September 6, 2024 22:02
@bact bact added publishing ci Dev workflow and repo management labels Sep 6, 2024
@bact bact added this to the 3.0.1 milestone Sep 6, 2024
@bact bact mentioned this pull request Sep 6, 2024
Closed
bact and others added 3 commits September 7, 2024 09:24
@bact @zvr
Install fake pandoc
6c3a577 
Create a doing-nothing "pandoc" script to bypass the Tex generation of spec-parser

Signed-off-by: Arthit Suriyawongkul <[email protected]>
Co-Authored-By: Alexios Zavras (zvr) <[email protected]>
@bact
Merge branch 'ci-update-for-spec-parser-2.5.0' of https://github.com/…
e20f267 
…bact/spdx-spec into ci-update-for-spec-parser-2.5.0
@bact
Remove pandoc installation-related
4452656 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact mentioned this pull request Sep 7, 2024
Closed
@bact
Add comments
56c7a15 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
goneall
goneall approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kestewart
Copy link
Contributor

Discussed on call no issues.

@bact bact merged commit be70b45 into spdx:development/v3.0.1 Sep 10, 2024
2 checks passed
@bact bact deleted the ci-update-for-spec-parser-2.5.0 branch September 10, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneall goneall goneall approved these changes

@licquia licquia licquia approved these changes

@kestewart kestewart kestewart approved these changes

@zvr zvr Awaiting requested review from zvr

Assignees
No one assigned
Labels
ci Dev workflow and repo management publishing
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

CI Failing in build model step Update CI for new spec-parser output
4 participants
@bact @kestewart @goneall @licquia