Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix typo (definined to defined) #791

Merged
merged 2 commits into from
Oct 2, 2022

Conversation

ninoseki
Copy link

@ninoseki ninoseki commented Oct 1, 2022

Hello, thank you for creating & maintaining the standard!

I just noticed a typo in the JSON schema. (definined)
So let me create a PR to fix that.

@seabass-labrax
Copy link
Contributor

Welcome to SPDX, and thank you @ninoseki! 😃

@goneall
Copy link
Member

goneall commented Oct 1, 2022

@ninoseki turns out this same typo is in all the examples - would you mind doing a search/replace and update this PR with updated examples with the same fix?

@ninoseki
Copy link
Author

ninoseki commented Oct 2, 2022

Sorry I missed them. I addressed them by e10ba8e.

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall
Copy link
Member

goneall commented Oct 2, 2022

Thanks @ninoseki

@goneall goneall merged commit a76fb33 into spdx:development/v2.3.1 Oct 2, 2022
@ninoseki ninoseki deleted the fix-typo branch October 3, 2022 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants