Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarification for case-sensitivity for LicenseRef- #984

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

vargenau
Copy link
Contributor

@vargenau vargenau commented Jul 9, 2024

See #981

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves an inconsistency in the spec. Note that the SPDX Java tools does not currently support this clarification, however. There is an existing issue to track updating the SPDX Java tools.

Copy link
Member

@zvr zvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I would also add this line to the previous paragraph (after "case insensitive.") instead of having it as a separate paragraph.

@zvr zvr added this to the 3.0.1 milestone Jul 16, 2024
@vargenau
Copy link
Contributor Author

@zvr
Merging is blocked by DCO.
Should I do something?

@bact
Copy link
Collaborator

bact commented Jul 16, 2024

@vargenau DCO requires you to signed-off the commit again (for every commits).

@vargenau
Copy link
Contributor Author

@vargenau DCO requires you to signed-off the commit again (for every commits).

Is it me or @zvr as he made a change to my commit?

@bact
Copy link
Collaborator

bact commented Jul 17, 2024

Anyone who actually make the commit.
(in this case, zvr only suggested the change but not actually commit the change himself).

Try this to rebase https://github.com/spdx/spdx-spec/pull/984/checks?check_run_id=27520863733
(not always successful, to my experience, as there can be some conflicts that can't be rebased. but still worth a try)

@vargenau
Copy link
Contributor Author

Anyone who actually make the commit. (in this case, zvr only suggested the change but not actually commit the change himself).

Try this to rebase https://github.com/spdx/spdx-spec/pull/984/checks?check_run_id=27520863733 (not always successful, to my experience, as there can be some conflicts that can't be rebased. but still worth a try)

Thank you @bact for your help. It's done.

Please merge.

vargenau and others added 2 commits July 29, 2024 21:25
Co-authored-by: Alexios Zavras (zvr) <[email protected]>
Signed-off-by: Marc-Etienne Vargenau <[email protected]>
@goneall goneall force-pushed the case-sensitivity branch from 69879fc to 095f3fa Compare July 30, 2024 04:25
@goneall
Copy link
Member

goneall commented Jul 30, 2024

It looks like the requested change from @zvr has been made, going ahead and merging.

@goneall goneall merged commit 5c7dd75 into spdx:development/v3.0.1 Jul 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants