Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Import Attachments page for Workbench #6257

Draft
wants to merge 13 commits into
base: issue-6074
Choose a base branch
from
Draft

Conversation

alesan99
Copy link
Contributor

@alesan99 alesan99 commented Feb 19, 2025

Fixes #6075

image

TODO
Needs PR #6269 first

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone
  • Add relevant documentation (Tester - Dev)
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • TODO
  • Go to the workbench and click "Import Attachments".
  • Select any number of files to upload.
  • Set the name of the data set.
  • Click Import files.
  • Choose a base table
  • Check that the data set contains a list of valid SpDataSetAttachment IDs (The ids can be checked with Query Builders)

Temporarily disable dataset loading
Remove dataset testing stuff
@alesan99 alesan99 added this to the 7.11 milestone Feb 20, 2025
@alesan99 alesan99 changed the base branch from production to issue-6074 March 4, 2025 17:13
@alesan99
Copy link
Contributor Author

alesan99 commented Mar 12, 2025

TODO:

  • More util functions, less copy-pasted code
  • Add handling for failed attachment uploads (Retry & rollback uploads if not all attachments were uploaded successfully)
  • Preview files to be uploaded. A bulk upload view would be ideal, but a spreadsheet preview would be simpler.
  • Add an upload progress bar like bulk attachment upload.
  • Fix SpDataSetAttachments not actually being uploaded to database

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋Back Log
Development

Successfully merging this pull request may close these issues.

Add Import Attachments page for the workbench (WB Attachments V1)
1 participant