Allow Helm Chart deploy image from digest #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharmanderJieniJieni
force-pushed
the
GkeBinAuth
branch
from
47510d7 to
f26b337
Compare
MuneebAijaz
reviewed
Nov 6, 2024
deployments/kubernetes/chart/reloader/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
karl-johan-grahn
previously approved these changes
Nov 13, 2024
|
@CharmanderJieniJieni looks good, please just resolve the conflict before we merge this |
CharmanderJieniJieni
force-pushed
the
GkeBinAuth
branch
from
cf46946 to
a822163
Compare
|
@karl-johan-grahn patched against latest commits |
|
hi @CharmanderJieniJieni can u pls rebase on master branch, and update helm chart version prematurely in chart.yaml? |
GKE Binary Authorization only supports image pull by digest - [Ref](https://cloud.google.com/binary-authorization/docs/deploying-containers#deploy_the_container_image) * if `.values.reloader.deployment.image.digest` is defined, pull image from digest * otherwise pull image from tag
CharmanderJieniJieni
force-pushed
the
GkeBinAuth
branch
from
a822163 to
b433a2d
Compare
done |
|
@CharmanderJieniJieni pls rebase again. sorry for the trouble |
MuneebAijaz
previously approved these changes
Jan 15, 2025
MuneebAijaz
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GKE Binary Authorization only supports image pull by digest - Ref
.values.reloader.deployment.image.digestis defined, pull image from digest