Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update js_of_ocaml to 5.5.2 #1381

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Update js_of_ocaml to 5.5.2 #1381

merged 1 commit into from
Dec 8, 2023

Conversation

WardBrian
Copy link
Member

@WardBrian WardBrian commented Dec 8, 2023

The recent 5.5 release of js_of_ocaml featured some pretty big improvements to the dead code elimination phase which makes the produced file smaller. On my machine, this is a nearly 15% improvement:

-r--r--r--  1 brian brian 1873308 Dec  8 10:13 stancjs.4.1.0.bc.js
-r--r--r--  1 brian brian 1608773 Dec  8 10:18 stancjs.5.5.2.bc.js

In terms of speed, it seems to be essentially the same, maybe slightly faster, but definitely within the range that the noise on my machine makes benchmarking unable to tell the difference between the two versions.

Submission Checklist

  • Run unit tests
  • Documentation
    • If a user-facing facing change was made, the documentation PR is here:
    • OR, no user-facing changes were made

Release notes

Updated js_of_ocaml to version 5.5.2

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #1381 (3433c6a) into master (992ff90) will increase coverage by 89.93%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1381       +/-   ##
===========================================
+ Coverage        0   89.93%   +89.93%     
===========================================
  Files           0       63       +63     
  Lines           0    10699    +10699     
===========================================
+ Hits            0     9622     +9622     
- Misses          0     1077     +1077     

see 63 files with indirect coverage changes

@WardBrian WardBrian merged commit 02a3a85 into master Dec 8, 2023
@WardBrian WardBrian deleted the update/js-of-ocaml-5.5.2 branch December 8, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants