Add fatal_error() to the language
#1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1402 +/- ##
==========================================
- Coverage 89.88% 89.87% -0.02%
==========================================
Files 63 63
Lines 10513 10525 +12
==========================================
+ Hits 9450 9459 +9
- Misses 1063 1066 +3
|
|
I prefer |
|
Good point. |
WardBrian
changed the title
exit() to the languagefatal_error() to the language
nhuurre
approved these changes
Feb 28, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1393 .
Note that there is no way to parse this and also allow variables named
exit, so this would immediately reserve the keyword. Based on a github search, I found only one package which usesexitas a variable name. If this is a serious concern we could consider different names likestopor something likefatal_errorwhich is almost certainly unused.Submission Checklist
Release notes
Added
fatal_error(), which is similar toreject()but rather than signaling an error which is recoverable, signals an error which should terminate execution immediately.fatal_erroris now a reserved word.Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)