Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sampling statement to distribution statement #1426

Merged
merged 3 commits into from
May 22, 2024

Conversation

WardBrian
Copy link
Member

Submission Checklist

Release notes

Rename sampling statement (~) to distribution statement (~) to be consistent with the docs changes in stan-dev/docs#777

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

@WardBrian WardBrian changed the title Rename sampling distribution Rename sampling statement to distribution statement May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.83%. Comparing base (2c42646) to head (9f9f557).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1426   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files          63       63           
  Lines       10484    10484           
=======================================
  Hits         9418     9418           
  Misses       1066     1066           
Files Coverage Δ
src/analysis_and_optimization/Pedantic_analysis.ml 93.30% <ø> (ø)
src/frontend/Typechecker.ml 91.89% <100.00%> (ø)
src/frontend/Semantic_error.ml 90.99% <83.33%> (ø)

Copy link
Contributor

@avehtari avehtari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (and better than my PR)

@WardBrian WardBrian merged commit 3f0b2a6 into master May 22, 2024
3 checks passed
@WardBrian WardBrian deleted the rename-sampling-distribution branch May 22, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants