Expose beta_neg_binomial_lpmf #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SteveBronder I couldn't tell if these signatures supported SoA or not -- do they? |
|
@serban-nicusor-toptal this is getting an odd error in the expression tests, can you take a look? It looks like something isn't being deleted properly between runs |
|
Yes how it's written it should |
This reverts commit 233a194.
|
This is now passing, mind approving @SteveBronder? @lingium The next step is documenting the distribution for users at https://github.com/stan-dev/docs/tree/master/src/functions-reference -- would you mind giving that a go? |
|
@WardBrian Sure, I can take care of that |
SteveBronder
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From stan-dev/math#3108 (ping @lingium)
Submission Checklist
Release notes
Exposed new distribution
beta_neg_binomialCopyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)