Type configs using literal types #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using `as const` on the string values for each of the rule configs, we ensure that the generated rules have string literal types matching their configured values. Fixes storybookjs#181
yannbf
approved these changes
Nov 18, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #181
What Changed
By using
as conston the string values for each of the rule configs, we ensure that the generated rules have string literal types matching their configured values. This allows it to satisfy the types required by the ESLint config type, which requires'error' | 'warn' | 'off' | ...Checklist
Check the ones applicable to your change:
pnpm run update-allChange Type
Indicate the type of change your pull request is:
maintenancedocumentationpatchminormajor