Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove esbuild step #13132

Merged
merged 5 commits into from
Dec 27, 2024
Merged

feat: remove esbuild step #13132

merged 5 commits into from
Dec 27, 2024

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Dec 10, 2024

closes #12813
closes #12373
closes #13005

This PR removes the esbuild step from the Cloudflare adapter since Wrangler now bundles the worker for us when deploying from the Cloudflare dashboard or via the Wrangler CLI. #13072 (comment) A similar change has been implemented in the cloudflare workers PR


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: e5ceb45

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino
Copy link
Member Author

eltigerchino commented Dec 10, 2024

Not sure why but when testing with pkg.pr.new, the prepublish step isn't run for the cloudflare adapter.

@svelterust

This comment was marked as duplicate.

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13132-svelte.vercel.app/

this is an automated message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants