Additional change to #398: Log traceback to track bug.

sympa-community · Aug 23, 2018 · e02945f · e02945f
1 parent 3fb13ff
commit e02945f
Showing 1 changed file with 14 additions and 8 deletions.
diff --git a/src/lib/Sympa/User.pm b/src/lib/Sympa/User.pm
@@ -645,12 +645,15 @@ sub update_global_user {
     ## avoid rehashing passwords that are already hash strings
     if ($values->{'password'}) {
         if (defined(hash_type($values->{'password'}))) {
-            $log->syslog('debug',
-                         'password is in %s format, not rehashing',
-                         hash_type($values->{'password'}));
+            $log->syslog(
+                'err',
+                'Bug in logic: Password is in %s format, not rehashing',
+                hash_type($values->{'password'})
+            );
         } else {
             $values->{'password'} =
-                Sympa::User::password_fingerprint($values->{'password'}, undef);
+                Sympa::User::password_fingerprint($values->{'password'},
+                undef);
         }
     }
 
@@ -733,12 +736,15 @@ sub add_global_user {
     ## avoid rehashing passwords that are already hash strings
     if ($values->{'password'}) {
         if (defined(hash_type($values->{'password'}))) {
-            $log->syslog('debug',
-                         'password is in %s format, not rehashing',
-                         hash_type($values->{'password'}));
+            $log->syslog(
+                'err',
+                'Bug in logic. Password is in %s format, not rehashing',
+                hash_type($values->{'password'})
+            );
         } else {
             $values->{'password'} =
-                Sympa::User::password_fingerprint($values->{'password'}, undef);
+                Sympa::User::password_fingerprint($values->{'password'},
+                undef);
         }
     }