Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: domains blacklist #295

Closed
ldidry opened this issue May 15, 2018 · 4 comments
Closed

Feature request: domains blacklist #295

ldidry opened this issue May 15, 2018 · 4 comments
Assignees
Milestone

Comments

@ldidry
Copy link
Contributor

ldidry commented May 15, 2018

Some people migrating lists from <whatever, I don't know> to our Sympa registers people with some well-known abandoned addresses. In France, we got voila.fr that is still registered but without mail server (and it will not change, it's owned by a big ISP that shut down the mail server a few years ago).

I suggest a domains blacklist setting that will prevents addresses using those domains to subscribe to list (a message saying "Sorry, that domain is blacklisted" to the subscribing action instigator could be cool)

ldidry added a commit to ldidry/sympa that referenced this issue Nov 9, 2018
ldidry added a commit to ldidry/sympa that referenced this issue Nov 13, 2018
@ldidry ldidry self-assigned this Nov 16, 2018
ldidry added a commit to ldidry/sympa that referenced this issue Nov 16, 2018
ldidry added a commit to ldidry/sympa that referenced this issue Nov 16, 2018
ldidry added a commit to ldidry/sympa that referenced this issue Nov 20, 2018
@ldidry ldidry added the ready A PR is waiting to be merged. Close to be solved label Dec 21, 2018
@ikedas ikedas closed this as completed in 101b3d6 Jan 10, 2019
ikedas added a commit that referenced this issue Jan 10, 2019
@ikedas ikedas removed the ready A PR is waiting to be merged. Close to be solved label Jan 10, 2019
@ikedas ikedas added this to the 6.2.40 milestone Jan 10, 2019
@dverdin
Copy link
Contributor

dverdin commented Jan 10, 2019

I arrive a bit late but did you know that Sympa can do this already?
for each list, you can set a blacklist. If your blacklist entry looks like "*@domain.tld", you blacklist the whole domain.
This blacklist is automatically used by any Sympa list.
It can be defined at the server or virtual host level, as it is a scenario.
You could also have used implicit scenarios inclusion.
In other words: you already had solutions in Sympa without the hasle of writing new code.

Remember: most of the time, any problem in Sympa can be solved by a scenario.

Consequently, I think that PR #478 is irrelevant and should be removed. I think it is counter-productive to use a different mechanism than the one already existing. It adds only confusion.

As it is obviously aimed at being used by listmaster, there is no immediate reason to make it available from the web interface.

@dverdin dverdin reopened this Jan 10, 2019
@ikedas
Copy link
Member

ikedas commented Jan 10, 2019

@dverdin, I don't agree to remove PR #478. That is, I think we'd be better to discuss on pros and cons of both solutions (scenario-based blacklist and this domain blacklist) so that we can find better way to improve Sympa.

How about opening a new issue? (Thus, I refrain from objecting your arguments by now.)

@ikedas ikedas removed the invalid label Jan 10, 2019
@dverdin
Copy link
Contributor

dverdin commented Jan 10, 2019

I thought it was the right place to do so as this issue is where the problem arose.
But if you want, I can do this someplace else.

@dverdin
Copy link
Contributor

dverdin commented Jan 10, 2019

OK, I posted a more elaborated issue here: #523.
I must admit that scenario are not immediately usable in that case, but I maintain that we should adapt Luc's solution to make a better usage of existing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants