Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sympa sysv init script not LSB compiliant #376

Closed
LAKostis opened this issue Jul 13, 2018 · 3 comments
Closed

Sympa sysv init script not LSB compiliant #376

LAKostis opened this issue Jul 13, 2018 · 3 comments
Labels
bug
Milestone
6.2.36

Comments

@LAKostis
Copy link
Contributor

LAKostis commented Jul 13, 2018 •
edited
Loading

Version:

sympa-6.2.24-1.20171222.RHEL6.x86_64

Installation method

rpm

Expected behavior

According LSB specification init script should return different exit codes for every status:
(http://refspecs.linuxbase.org/LSB_3.0.0/LSB-PDA/LSB-PDA/iniscrptact.html)

0 | program is running or service is OK
-- | --
1 | program is dead and /var/run pid file exists
2 | program is dead and /var/lock lock file exists
3 | program is not running
4 | program or service status is unknown
5-99 | reserved for future LSB use
100-149 | reserved for distribution use
150-199 | reserved for application use
200-254 | reserved

Actual behavior

# service sympa status; echo "$?"
Status of Sympa subsystem: 
Status file for subsystem NOT found.
sympa_msg.pl is stopped
bulk.pl is stopped
archived.pl is stopped
bounced.pl is stopped
task_manager.pl is stopped
0

Additional information

# rpm -qf /etc/init.d/sympa 
sympa-6.2.24-1.20171222.RHEL6.x86_64

I think this bug also exists in 6.2.34, but haven't checked yet.
@LAKostis
Copy link
Contributor Author

Simple fix for this

@ikedas
Copy link
Member

ikedas commented Jul 14, 2018

Hi @LAKostis,
Could you please you submit your fix as pull request?

@ikedas ikedas added the bug label Jul 14, 2018
LAKostis added a commit to LAKostis/sympa that referenced this issue Jul 16, 2018
@LAKostis
sympa.in: make sysv script LSB friendly
c68aa72 
sympa-community#376

Currently sysv script always return 0 even if service is stopped which breaks
many checks which rely on LSB standards.

Signed-off-by: Konstantin A. Lepikhov <[email protected]>
@LAKostis LAKostis mentioned this issue Jul 16, 2018
Merged
@ikedas ikedas added this to the 6.2.36 milestone Jul 16, 2018
@ikedas
Copy link
Member

ikedas commented Aug 16, 2018

Fix was merged. Thank you for improving Sympa!

@ikedas ikedas closed this as completed Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
6.2.36
Development

No branches or pull requests
2 participants
@ikedas @LAKostis