Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of missing sympa/web_tt2 during upgrade #652

Closed
paulmenzel opened this issue Jun 12, 2019 · 1 comment · Fixed by #653
Closed

Improve handling of missing sympa/web_tt2 during upgrade #652

paulmenzel opened this issue Jun 12, 2019 · 1 comment · Fixed by #653
Assignees
@ikedas
Labels
bug ready A PR is waiting to be merged. Close to be solved
Milestone
6.2.44

Comments

@paulmenzel
Copy link

Upgrading from 6.1.23 to 6.2.16 with /usr/lib/sympa/bin/sympa.pl --upgrade shows the error below.

notice Sympa::Upgrade::fix_colors() /etc/sympa/sympa/sympa.conf file saved as /etc/sympa/sympa/sympa.conf.upgrade12.Jun.2019-14.00.23
err main::#797 > Sympa::Upgrade::upgrade#1345 > Sympa::Upgrade::save_web_tt2#2020 /etc/sympa/web_tt2 directory is not writable: No such file or directory. Unable to rename it. Web interface might look buggy after upgrade

If the directory /etc/sympa/web_tt2 does not exist, no error should be shown (maybe a notice). It seems totally fine, that it is missing, if no customizations were made.

Additionally, no empty backup directory /etc/sympa/web_tt2.upgrade12.Jun.2019-13.25.58/ should be created.

Version

6.2.16~dfsg-3+deb9u2

Installation method

Debian 9
@paulmenzel paulmenzel changed the title Better deal with missing sympa/web_tt2 during upgrade Improve handling of missing sympa/web_tt2 during upgrade Jun 12, 2019
@ikedas ikedas added the bug label Jun 12, 2019
@ikedas ikedas self-assigned this Jun 12, 2019
@ikedas ikedas mentioned this issue Jun 13, 2019
Merged
@ikedas
Copy link
Member

ikedas commented Jun 13, 2019

Hi @paulmenzel,
Could you please check the PR above? Thank you.

@ikedas ikedas added the ready A PR is waiting to be merged. Close to be solved label Jun 13, 2019
@ikedas ikedas added this to the 6.2.44 milestone Jun 13, 2019
ikedas added a commit that referenced this issue Jun 19, 2019
@ikedas
Merge pull request #653 from ikedas/issue-652 by ikedas
274d6f1 
Improve handling of missing `sympa/web_tt2` during upgrade #652
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikedas ikedas

Labels
bug ready A PR is waiting to be merged. Close to be solved
Projects
None yet
Milestone
6.2.44
Development

Successfully merging a pull request may close this issue.

Improve handling of missing sympa/web_tt2 during upgrade #652 ikedas/sympa
2 participants
@ikedas @paulmenzel