-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mail_tt2/moderate.tt2 : mailto: links intermittantly line wrapped #709
Comments
Text::LineFold names only Prep. I suppose we can safely remove the prep option. |
https://metacpan.org/changes/distribution/Unicode-LineBreak about version 2019.001:
The latest release is preferred. Using keys “Prep” and “prep” (they are not unique in cases) is workaround for earlier releases. |
OK, but we could determine the right key by looking at the Text::LineFold version? |
However, many distributions do not bundle 2019.001. That's why I didn't update |
@dpc22, could you please show versions of these?
Thanks. |
I checked if wrapping reproduces using @dpc22's test script on my environment.
(N.B.: sombok 2.4.0, libthai 0.1.14 and Perl 5.16.3 are installed with RPM. Others are isntalled from source.) This looks due to hash randomization introduced by recent Perl. U-L 2019.001 won't be affacted by such randomization. @racke, you are right. We have to introduce recent version of U-L. |
Ubuntu 18.04:
RHEL 7:
All of which should be the latest versions for those distributions. RHEL 7 is actually the platform that I care about for a production environment: Ubuntu is just running on my workstation as a test platform. RHEL 7 does seems to work at the moment, although it is clearly using quite an old version of perl-Unicode-LineBreak-2. |
@dpc22 thanks for information. I prepared U-L-2019.001 for RHEL7. Could you please check if it will solve the problem? |
That RPM certainly seems to work on RHEL 7: thank you. As it happens the existing perl-Unicode-LineBreak-2016.003-1 seemed to be working anyway (presuming using the prep/Prep workaround). However there is no guarantee that Redhat won't update to a broken version in the next 7.x release, so having a workaround is really helpful. Thanks. |
Unicode::LineBreak is not in base RHEL/CentOS but in the EPEL add-on repo. As I'm the maintainer for this package, I have updated it to 2019.001 for EL7, EL6 and F29 (F30 and F31 are already shipping 2019.001). It should appear soon in updates-testing/epel-testing repos. Please note sympa itself is on its way to Fedora/EPEL (already available in updates-testing/epel-testing) and the sympa COPR repo will likely disappear in a not too distant future. I'll keep the sympa-beta COPR repo for testing purpose though. |
@xavierba, thanks for quick work! And thanks much for maintenance of RPM packages! U-L-2019.001 RPM created by me, if it has already been installed, will be safely updated by EPEL package. |
Version
6.2.44 on Ubuntu 18.04 and RHEL 7
Installation method
Ubuntu 18.04: From source
RHEL 7: rpm from https://copr.fedorainfracloud.org/coprs/xavierb/sympa/
Expected behavior
mailto: links generated by mail_tt2/moderate.tt2 : should look something like:
Actual behavior
A line break is occasionally installed after the '-' character on Ubuntu 18.04 (but not RHEL 7),
so I end up with:
This doesn't work correctly when people click on the link. You end up with
rather than:
Additional information
Ubuntu 18.04 is using libunicode-linebreak-perl 0.0.20160702-1build
RHEL is using perl-Unicode-LineBreak-2016.003-1.el7.x86_64
I think that the problem is the following in .../lib/Sympa/Tools/Text.pm
as that works reliably on Ubuntu 18.04 if I remove the second line.
I attach a small Perl test script:
test-unicode-linebreak.pl.txt
which works reliability on RHEL 7 but erratically on Ubuntu 18.04
The text was updated successfully, but these errors were encountered: