The owner sees the pop-up stating a message is waiting for moderation even if moderators are defined separately (#1406)

[ikedas]

This may fix #1406.

[tmclaren]

What was the proposed solution?

[ikedas]

As I wrote, the 'owner who does not double moderator should not see the pop-up about "message(s) awiting moderation", as they does not see about such messages in the side menu'.

[tmclaren]

This is not a solution. This approach obfuscates the privileged owners view into the moderation queue when moderators are defined.

[ikedas]

As I wrote, (1) if the owner want to view it, they can give the role of moderator to themselves. OTOH (2) some owners may not want to view everything by their own.
Currently Sympa's default behavior is 2, and 1 needs optional setting.

If you want to make 1 the default behavior of Sympa, i.e. to make 2 optional, you would be better to submit a separate issue.

[EDIT] Additional note: Currently only moderators will receive notification about moderation by email. Owner not designated to moderator won't, even if they are "privileged". If you prefer to change such a behavior of Sympa, please submit new issue.

[ikedas]

@tmclaren , please try it: When you are a (privileged) owner, please add yourself as a moderator too, then check if the pop-up about moderation is shown. That's what this PR intended.

[tmclaren]

I realize the owner could add themselves to the moderator's list but that has side effects:

1. they will start receiving the automated messages from the server when a message is waiting for moderation in addition to seeing the queue in the web UI. Many list owners do not want that extra email event since they've assigned others to moderate.
2. they will see the moderation queue when they log into the UI.

A privileged list owner should not be restricted from seeing the moderation queue when they assigned other persons to moderate the list. Think about the professor and teaching assistant (TA) relationship: Prof creates and configures a class list and the TA moderates the lists. However, the Prof will spot check the list to verify all inbound messages are being moderated in a timely manner. They should be able to see the moderation queue when the log into the web UI. Sadly, this change prevents the privileged owner from ever seeing the moderation queue and IMHO has only made this issue worse.

I still recommend, the privileged list owner get the popup message about pending moderation messages AND the left menu reflect the same information. In general, I believe the privileged list owner should NOT be restricted from their mail list settings or behavior unless the listmaster has configured the server to specifically restrict the view of a setting/behavior in the ~/edit_list.conf.

[ikedas]

@tmclaren , here is a pull request that has already been merged and closed. Please submit the new issue for discussion.

[tmclaren]

Unfortunate! You are obfuscating a fundamental permission for privileged owners. Hopefully this hack will get documented as a caveat in the owners doc. Sad…

…

On Mon, Jun 6, 2022 at 7:09 PM IKEDA Soji ***@***.***> wrote: As I wrote <#1406 (comment)>, the 'owner who does not double moderator should not see the pop-up about "message(s) awiting moderation", as they does not see about such messages in the side menu'. — Reply to this email directly, view it on GitHub <#1409 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXO2KSD6S73R6YB7EOKOWTVN2HK5ANCNFSM5XX3CNRQ> . You are receiving this because you commented.Message ID: ***@***.***>

[ikedas]

See "Roles and privileges".

It does not state that the owner should see the moderation queue as the moderator does: It states that

• the privileged owners are "responsible for managing the list owners and moderators themselves".
• the owners are "responsible for managing the members of the list",
• the moderators are "responsible for the messages distributed in the mailing list (as opposed to owners who look after list members)."

It is your arguement that the owners should be able to see the moderation queue even if they didn't double the moderator. If you want to change Sympa as you argue, please make appropriate suggestions in #1428.