Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Fix some problems (#1753) (#1761) (#1763) (#1767) #1783

Merged
merged 5 commits into from
Feb 17, 2024
Merged

Accessibility: Fix some problems (#1753) (#1761) (#1763) (#1767) #1783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e53c9af
Accessibility: Home submenu should have proper landmark role (#1753)
ikedas Dec 18, 2023
134e9eb
Accessibility: Landmarks should be uniquely labelled (#1761)
ikedas Dec 18, 2023
f3bdd5e
Accessibility: `for` attribute of `label` element should refer to for…
ikedas Dec 23, 2023
89caacb
Accessibility: Data cells in complex tables should have `headers` att…
ikedas Dec 29, 2023
9d96b10
Merge branch 'main' into issue-1753+1761
ikedas Dec 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions default/web_tt2/active_lists.tt2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
<table class="responsive listOfItems" >
<caption>[%|loc(count)%] The %1 most active lists [%END%][%|loc(for)%] for %1 days [%END%]</caption>
<tr class="color_light">
<th id="list_name"><strong>[%|loc%]List name[%END%]</strong></th>
<th id="message"><strong>[%|loc%]Number of messages[%END%]</strong></th>
<th id="average"><strong>[%|loc%]Average by day[%END%]</strong></th>
<th id="date"><strong>[%|loc%]Creation date[%END%]</strong></th>
<th id="subject"><strong>[%|loc%]Subject[%END%]</strong></th>
<th id="h_name"><strong>[%|loc%]List name[%END%]</strong></th>
<th id="h_number"><strong>[%|loc%]Number of messages[%END%]</strong></th>
<th id="h_average"><strong>[%|loc%]Average by day[%END%]</strong></th>
<th id="h_date"><strong>[%|loc%]Creation date[%END%]</strong></th>
<th id="h_subject"><strong>[%|loc%]Subject[%END%]</strong></th>
</tr>

[% SET dark = '0' %]
Expand All @@ -34,13 +34,13 @@
<tr class="color0">
[% SET dark = '1' %]
[% END %]
<td headers="list_name">
<td headers="h_name">
<a href="[% 'info' | url_rel([l.name]) %]" ><strong>[%|obfuscate(conf.spam_protection) %][% l.name %]@[% domain %][% END %]</strong></a>
</td>
<td class="text_center" headers="message"> [% l.msg_count %] </td>
<td class="text_center" headers="average"> [% l.average %] </td>
<td headers="date"> [% l.date %] </td>
<td headers="subject"> [% l.subject %] </td>
<td headers="h_number" class="text_center"> [% l.msg_count %] </td>
<td headers="h_average" class="text_center"> [% l.average %] </td>
<td headers="h_date"> [% l.date %] </td>
<td headers="h_subject"> [% l.subject %] </td>
</tr>
[% END %]
</table>
Expand Down
10 changes: 6 additions & 4 deletions default/web_tt2/aside_menu.tt2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,14 @@
<i class="fa fa-envelope-square fa-lg"></i>
</span>
<div class="title-bar-right">
<div class="title-bar-title">
<div class="title-bar-title" id="sympa-sub-bar-title">
<span>[%|loc%]List Options Menu[%END%]</span>
</div>
<a class="menu-icon" href="#" data-toggle="sympa-sub-bar"></a>
</div>
</div>
<nav class="top-bar" id="sympa-sub-bar" role="navigation">
<nav class="top-bar" id="sympa-sub-bar"
role="navigation" aria-labelledby="sympa-sub-bar-title">
<menu class="top-bar-left list">
<ul class="vertical menu" data-responsive-menu="drilldown medium-accordion">
[% PROCESS list_menu.tt2 %]
Expand Down Expand Up @@ -44,14 +45,15 @@
[%~ END %]
</span>
<div class="title-bar-right">
<div class="title-bar-title">
<div class="title-bar-title" id="sympa-sub-bar-title">
<span>[%|loc%]General Menu[%END%]</span>
</div>
<a class="menu-icon" href="#" data-toggle="sympa-sub-bar"></a>
</div>
</div>

<nav class="top-bar" id="sympa-sub-bar" role="navigation">
<nav class="top-bar" id="sympa-sub-bar"
role="navigation" aria-labelledby="sympa-sub-bar-title">
[% IF user.email ~%]
<menu class="top-bar-left user">
<ul class="nested vertical menu">
Expand Down
4 changes: 2 additions & 2 deletions default/web_tt2/create_list_request.tt2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
<label for="listname">[%|loc%]List name:[%END%]</label>
<input type="text" id="listname" name="listname" size="30" value="[% saved.listname %]" />

<label for="owner">[%|loc%]Owner:[%END%]</label> <span>[% user.email %]</span>
<label for="list_type">[%|loc%]List type:[%END%]</label>
<label>[%|loc%]Owner:[%END%]</label> <span>[% user.email %]</span>
<label>[%|loc%]List type:[%END%]</label>
<ul id="list_type">
[%~ FOREACH tpl_info = list_list_tpl %]
<li>
Expand Down
66 changes: 41 additions & 25 deletions default/web_tt2/d_read.tt2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,56 +89,72 @@
<caption>[%|loc%]Listing of folder[%END%] [% shared_doc.name %]</caption>
<tr>
[% IF order_by != 'order_by_doc' ~%]
<th><a href="[% 'd_read' | url_rel([list,shared_doc.paths_d],{order=>'order_by_doc'}) %]">[%|loc%]Document[%END%]</a> </th>
<th id="h_name">
<a href="[% 'd_read' | url_rel([list,shared_doc.paths_d],{order=>'order_by_doc'}) %]">
[%|loc%]Document[%END%]
</a>
</th>
[%~ ELSE ~%]
<th class="sortby">[%|loc%]Document[%END%]</th>
<th id="h_name" class="sortby">[%|loc%]Document[%END%]</th>
[%~ END %]

[% IF order_by != 'order_by_author' ~%]
<th><a href="[% 'd_read' | url_rel([list,shared_doc.paths_d],{order=>'order_by_author'}) %]">[%|loc%]Author[%END%]</a> </th>
<th id="h_author">
<a href="[% 'd_read' | url_rel([list,shared_doc.paths_d],{order=>'order_by_author'}) %]">
[%|loc%]Author[%END%]
</a>
</th>
[%~ ELSE ~%]
<th class="sortby">[%|loc%]Author[%END%]</span></td>
<th id="h_author" class="sortby">[%|loc%]Author[%END%]</span></td>
[%~ END %]

[% IF order_by != 'order_by_size' ~%]
<th><a href="[% 'd_read' | url_rel([list,shared_doc.paths_d],{order=>'order_by_size'}) %]">[%|loc%]Size (Kb)[%END%]</a> </th>
<th id="h_size">
<a href="[% 'd_read' | url_rel([list,shared_doc.paths_d],{order=>'order_by_size'}) %]">
[%|loc%]Size (Kb)[%END%]
</a>
</th>
[%~ ELSE ~%]
<th class="sortby">[%|loc%]Size (Kb)[%END%]</th>
<th id="h_size" class="sortby">[%|loc%]Size (Kb)[%END%]</th>
[%~ END %]

[% IF order_by != 'order_by_date' ~%]
<th><a href="[% 'd_read' | url_rel([list,shared_doc.paths_d],{order=>'order_by_date'}) %]">[%|loc%]Last update[%END%]</a> </th>
<th id="h_date">
<a href="[% 'd_read' | url_rel([list,shared_doc.paths_d],{order=>'order_by_date'}) %]">
[%|loc%]Last update[%END%]
</a>
</th>
[%~ ELSE ~%]
<th class="sortby">[%|loc%]Last update[%END%]</span></td>
<th id="h_date" class="sortby">[%|loc%]Last update[%END%]</span></td>
[%~ END %]

[% IF expert_page ~%]
<th>[%|loc%]Actions[%END%]</th>
<th id="h_actions">[%|loc%]Actions[%END%]</th>
[%~ END %]
</tr>

[% IF shared_doc.children ~%]
[% FOREACH s = shared_doc.children ~%]
[% NEXT UNLESS s.type == 'directory' ~%]
<tr class="color0">
<td class="review_cels_mail">
<td headers="h_name" class="review_cels_mail">
<a href="[% 'd_read' | url_rel([list,s.paths_d]) %]">
[% PROCESS SharedGetIcon shared_item = s %]
[% s.name %]
</a>
</td>
<td class="review_cels">
<td headers="h_author" class="review_cels">
[% IF s.owner ~%]
[% s.owner | mailto(s.owner) | obfuscate(listconf.spam_protection) %]
[%~ ELSE ~%]
[%|loc%]Unknown[%END%]
[%~ END ~%]
</td>
<td>&nbsp;</td>
<td class="review_cels"> [% s.date %] </td>
<td headers="h_date" class="review_cels"> [% s.date %] </td>

[% IF expert_page ~%]
<td class="review_cels text-right">
<td headers="h_actions" class="review_cels text-right">
[% IF s.may_edit ~%]
<a href="[% 'd_delete' | url_rel([list,s.paths_d],{previous_action=>action}) %]"
class="tip-left" data-tooltip aria-haspopup="true"
Expand Down Expand Up @@ -172,7 +188,7 @@
[% IF is_editor ~%]

[%~ END %]
</td>
</td>
[%~ END %]
</tr>
[%~ END %]
Expand All @@ -190,15 +206,15 @@
[%~ END %]

[% IF f.html ~%]
<td class="review_cels_mail">
<td headers="h_name" class="review_cels_mail">
<a href="[% 'd_read' | url_rel([list,f.paths_d]) %]"
title="[%|loc%]Open in a new window[%END%]" target="html_window">
[% PROCESS SharedGetIcon shared_item = f %]
[% f.name %]
</a>
</td>
[%~ ELSIF f.url ~%]
<td class="review_cels_mail">
<td headers="h_name" class="review_cels_mail">
<a href="[% f.url %]" title="[%|loc%]Open in a new window[%END%]"
target="html_window">
[% PROCESS SharedGetIcon shared_item = f %]
Expand All @@ -208,15 +224,15 @@
[%~ ELSE ~%]
[% IF f.moderate ~%]
[% IF expert_page ~%]
<td class="review_cels_mail">
<td headers="h_name" class="review_cels_mail">
<a href="[% 'd_read' | url_rel([list,f.paths_d]) %]">
[% PROCESS SharedGetIcon shared_item = f %]
[% f.name %]
</a>
</td>
[%~ END %]
[%~ ELSE ~%]
<td class="review_cels_mail">
<td headers="h_name" class="review_cels_mail">
<a href="[% 'd_read' | url_rel([list,f.paths_d]) %]">
[% PROCESS SharedGetIcon shared_item = f %]
[% f.name %]
Expand All @@ -227,10 +243,10 @@

[% IF f.moderate ~%]
[% IF expert_page ~%]
<td class="review_cels">[%|loc%]to moderate[%END%]</td>
<td headers="h_author" class="review_cels">[%|loc%]to moderate[%END%]</td>
[%~ END %]
[%~ ELSE ~%]
<td class="review_cels">
<td headers="h_author" class="review_cels">
[% IF f.owner.length ~%]
[% f.owner | mailto(f.owner) | obfuscate(listconf.spam_protection) %]
[%~ ELSE ~%]
Expand All @@ -241,24 +257,24 @@

[% IF f.moderate ~%]
[% IF expert_page ~%]
<td class="review_cels">&nbsp;
<td headers="h_size" class="review_cels">&nbsp;
[% IF !f.url ~%]
[% f.size %]
[%~ END %]
</td>
<td class="review_cels"> [% f.date %] </td>
<td headers="h_date" class="review_cels"> [% f.date %] </td>
[%~ END %]
[%~ ELSE ~%]
<td class="review_cels">&nbsp;
<td headers="h_size" class="review_cels">&nbsp;
[%~ IF !f.url ~%]
[% f.size %]
[%~ END ~%]
</td>
<td class="review_cels"> [% f.date %] </td>
<td headers="h_date" class="review_cels"> [% f.date %] </td>
[%~ END %]

[% IF expert_page ~%]
<td class="review_cels text-right">
<td headers="h_actions" class="review_cels text-right">
[% IF is_editor ~%]
[% IF f.moderate ~%]
[% IF expert_page ~%]
Expand Down
32 changes: 22 additions & 10 deletions default/web_tt2/edit_config.tt2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,27 @@
</ul>
<p>
[% SET close_table = '' %]
[% SET groupid = '' %]
[% FOREACH confparam IN editable_params %]
[% IF confparam.title %]
[% close_table %]
<a name="[%confparam.group%]"></a>
[% SET groupid = confparam.group %]
<a name="[%groupid%]"></a>
<h4>[% confparam.title %]</h4>
<table class="responsive listOfItems">
<tr>
<th>[%|loc%]parameter name[%END%]</th>
<th>[%|loc%]value[%END%]</th>
<th>[%|loc%]apply to[%END%]</th>
<th>[%|loc%]default[%END%]</th>
[%# <th>semantic</th> %]
<th id="h_name_[%groupid%]">
[%|loc%]parameter name[%END%]
</th>
<th id="h_value_[%groupid%]">
[%|loc%]value[%END%]
</th>
<th id="h_context_[%groupid%]">
[%|loc%]apply to[%END%]
</th>
<th id="h_default_[%groupid%]">
[%|loc%]default[%END%]
</th>
</tr>
[% ELSE %]
[% IF dark == '1' %]
Expand All @@ -35,27 +44,30 @@
[% SET dark='1'%]
<tr class="color0">
[% END %]
<td [% IF confparam.query %]
<td headers="h_name_[%groupid%]"
[% IF confparam.query ~%]
data-tooltip aria-haspopup="true"
title="[% confparam.query %]"
[%~ END %]>
<strong>[% confparam.name %]</strong>
</td>
<td>
<td headers="h_value_[%groupid%]">
[% UNLESS confparam.obfuscated == '1' %]
[% confparam.current_value %]
[% ELSE %]
[% confparam.current_value.replace('.','*') %]
[% END %]
</td>
<td>
<td headers="h_context_[%groupid%]">
[% IF confparam.vhost == '1' ~%]
[% robot %]
[%~ ELSE ~%]
[%|loc%]main conf[%END%]
[%~ END %]
</td>
<td>[% confparam.default %]</td>
<td headers="h_default_[%groupid%]">
[% confparam.default %]
</td>
</tr>
[% SET close_table = '</table>' %]
[% END %]
Expand Down
18 changes: 10 additions & 8 deletions default/web_tt2/get_biggest_lists.tt2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
<table class="responsive table_style">
<caption>[%|loc%]Biggests Lists[%END%]</caption>
<tr class="color_light">
<th>[%|loc%]Creation date[%END%]</th>
<th>[%|loc%]List name[%END%]</th>
<th>[%|loc%]Subject[%END%]</th>
<th>[%|loc%]Subscribers[%END%]</th>
<th id="h_date">[%|loc%]Creation date[%END%]</th>
<th id="h_name">[%|loc%]List name[%END%]</th>
<th id="h_subject">[%|loc%]Subject[%END%]</th>
<th id="h_value">[%|loc%]Subscribers[%END%]</th>
</tr>

[% FOREACH list = biggest_lists %]
Expand All @@ -15,10 +15,12 @@
[% ELSE %]
<tr class="color0">[% SET dark = 1 %]
[% END %]
<td>[% list.creation_date_epoch | optdesc('unixtime') %]</td>
<td><a href="[% 'admin' | url_rel([list.name]) %]">[% list.name %]</a></td>
<td>[% list.subject %]</td>
<td>[% list.subscribers %]</td>
<td headers="h_date">[% list.creation_date_epoch | optdesc('unixtime') %]</td>
<td headers="h_name">
<a href="[% 'admin' | url_rel([list.name]) %]">[% list.name %]</a>
</td>
<td headers="h_subject">[% list.subject %]</td>
<td headers="h_value">[% list.subscribers %]</td>
</tr>
[% END %]
</table>
Expand Down
Loading