Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to activate pending lists with sympa.pl #645

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

ldidry
Copy link
Contributor

@ldidry ldidry commented Jun 7, 2019

  • Small change to --open_list to let it handle pending lists
  • Add --show_pending_lists=robot option to print pending lists (with some
    informations)

Fix #637

@ldidry ldidry requested review from racke, dverdin and ikedas June 7, 2019 13:13
@ldidry
Copy link
Contributor Author

ldidry commented Jun 7, 2019

🤔 It lacks a --reject-list option though. I’ll try to add it next week.

- Small change to --open_list to let it handle pending lists
- Add --show_pending_lists=robot option to print pending lists (with some
  informations)

Fix sympa-community#637
@ldidry
Copy link
Contributor Author

ldidry commented Aug 2, 2019

In fact, close_list can be used to reject pending list. No need for another option.

@ikedas, @racke, could you review this PR, please ?

Copy link
Member

@ikedas ikedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, close_list can be used to reject pending list. No need for another option.

Should we modify close_list handler?

@ikedas, @racke, could you review this PR, please ?

I have added a comment.

$main::options{'show_pending_lists'},
$list->{'admin'}{'subject'},
$list->{'admin'}{'creation'}{'email'},
$list->{'admin'}{'creation'}{'date_epoch'};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

date_epoch is Unix time. It would be better to be:

                $language->gettext_strftime('%d %b %Y at %H:%M:%S', $list->{'admin'}{'creation'}{'date_epoch'});

@ldidry
Copy link
Contributor Author

ldidry commented Aug 5, 2019

Should we modify close_list handler?

No.

Well, in fact, if we want to send a notification to the owner, we should (I don’t know if it would be hard). It should be a --notify option that could be used in combination with --close_list and --open_list. What do you think ?

@ikedas
Copy link
Member

ikedas commented Aug 5, 2019

Should we modify close_list handler?

No.

Well, in fact, if we want to send a notification to the owner, we should (I don’t know if it would be hard). It should be a --notify option that could be used in combination with --close_list and --open_list. What do you think ?

Oh sorry I see. You already have added mode attribute.
Currently --open_list does not have --notify option, and I think --close_list may also not have it.

I'll approve this pr and merge it later.

@ikedas ikedas merged commit 44fd66e into sympa-community:sympa-6.2 Aug 7, 2019
@ikedas ikedas modified the milestone: 6.2.46 Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle pending lists with sympa.pl
2 participants