Add ability to forbid some list names #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please get rid of the unnecessary white spaces in List.pm. Also I would like to make suggestions on the wording for messages and instructions. |
|
The white spaces in List.pm comes from perltidy so, if we want to pass perltidy test (I launch it in a pre-commit hook, but it’s launched in CI too), we need them. For the wording, please, go ahead, make suggestions 🙂 |
|
I would still prefer to kill whitespace in a separate PR. This makes reviewing more difficult IMHO. |
|
As you want 🙂 |
|
Done (PR: #677) |
ldidry
force-pushed
the
fix-672
branch
2 times, most recently
from
b2d5ae2 to
daec179
Compare
ikedas
reviewed
Jul 6, 2019
ikedas
reviewed
Jul 6, 2019
— Add prohibited_listnames setting (comma-separated list, with ability to use a wildcard) — Add prohibited_listnames_regex setting The settings are cumulative. You can use one or the other or both. May fix sympa-community#672
Thanks to @ikedas for the correction proposal
racke
approved these changes
Apr 6, 2020
ikedas
added a commit
that referenced
this pull request
Apr 27, 2021
Add ability to forbid some list names (#675)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to use a wildcard)
The settings are cumulative. You can use one or the other or both.
May fix #672