Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WWSympa: Use the label 'Apply modifications' instead of 'Update' #713

Merged
merged 3 commits into from
Aug 7, 2019

Conversation

ikedas
Copy link
Member

@ikedas ikedas commented Jul 31, 2019

Use 'Apply modifications' instead of 'Update' to make sure the changes/deletions will be effective only if update is performed. These functions are subject to the change: edit_list, editsubscriber/review/set and edit.

This may fix #698.

ikedas added 3 commits July 31, 2019 14:22
…sure the changes/deletion will be effective only if update is performed.
… of 'Update' to make sure the changes/deletion will be effective only if update is performed.
…make sure the changes/deletions will be effective only if update is performed.
@ikedas ikedas requested a review from ldidry July 31, 2019 05:31
@ikedas ikedas merged commit 7901db2 into sympa-community:sympa-6.2 Aug 7, 2019
@ldidry
Copy link
Contributor

ldidry commented Aug 7, 2019

Sorry, I didn’t saw that you asked for a review. Looks good to me 👍

Copy link
Contributor

@ldidry ldidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ikedas ikedas deleted the issue-698_01 branch August 8, 2019 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6.2.44 Cannot delete a moderator/owner
2 participants