Improved accessibility and Fixed main nav active states #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SameerJadav is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
docs/next.config.mjs
Outdated
| @@ -7,6 +7,7 @@ import { getHighlighter } from "shiki"; | |||
|
|
|||
| /** @type {import('next').NextConfig} */ | |||
| const nextConfig = { | |||
| swcMinify: true, | |||
There was a problem hiding this comment.
this is on by default iirc
There was a problem hiding this comment.
yes, it is the default js compiler. i'll remove it from the config
| export function MainNav(props: { items: NavItem[] }) { | ||
| const pathname = usePathname(); | ||
| function isActive(href: string) { | ||
| const segment = useSelectedLayoutSegment(); |
There was a problem hiding this comment.
this doesn't adhere to rules of hooks
There was a problem hiding this comment.
i have moved it inside the component
export function MainNav() {
const segment = useSelectedLayoutSegment();
const isActive = (href: string) => {
if (!segment) return false;
return href.startsWith(`/${segment}`);
};
// ...
}is this okay?? if it is i will commit it
juliusmarminge
requested changes
Aug 16, 2023
i've added back the spacing |
juliusmarminge
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed the docs site to make it more accessible and improve SEO. I also fixed the issue where the main navigation links were not showing in their active state. Here are the details of the changes we made:
useSelectedLayoutSegment()hoverOnlyWhenSupported, which will prevent any hover styles from being shipped to devices that don't support hover (phones). You can look at the PR this feature was introduced in Only apply hover styles when supported (future) tailwindlabs/tailwindcss#8394We can also use 'next/images' in the docs and get all the benefits like lazy loading, blur placeholder, etc. and increase the performance even more. However, implementing this would require downloading each image.
Take your time to review the changes. I'm totally up for any feedback or suggestions you might have.