Ensure nested functions in selectors used with JavaScript plugins are not truncated #16802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
force-pushed
the
fix/selector-parser-bug
branch
from
e1e0a58 to
b575a6f
Compare
philipp-spiess
force-pushed
the
fix/selector-parser-bug
branch
from
b575a6f to
9fb7fdd
Compare
| }) | ||
|
|
||
| it('parses :not(:nth-child(1))', () => { | ||
| expect(parse('&:not(:nth-child(1))')).toEqual([ |
There was a problem hiding this comment.
This test is structurally identical to the :has(…) test above. Is it necessary?
There was a problem hiding this comment.
Not really, good catch. Removed!
thecrypticace
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16799
This was caused by a wrong condition in the CSS value parser that put child function arguments into the parent function by accident.
Test plan