Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert renaming whitespace-no-wrap to whitespace-nowrap #2675

Closed
wants to merge 2 commits into from

Conversation

adamwathan
Copy link
Member

@adamwathan adamwathan commented Oct 25, 2020

We shouldn't change this unless we also change flex-no-wrap to flex-nowrap. Changing multiple class names starts to feel like a more annoying breaking change, so going to revert this and reconsider. We'll either change both in a future commit, or just leave it as-is.

Small chance we just add flex-nowrap and whitespace-nowrap as aliases and stop documenting the versions with the extra dash, then remove in 3.0, but feels kinda stupid to introduce a deprecation instead of a break, especially one that affects the the CSS bundle size sent to the client.

@codecov-io
Copy link

codecov-io commented Oct 25, 2020

Codecov Report

Merging #2675 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2675   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files         172      172           
  Lines        1727     1727           
  Branches      304      304           
=======================================
  Hits         1606     1606           
  Misses        104      104           
  Partials       17       17           
Impacted Files Coverage Δ
src/plugins/whitespace.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a669180...a79f750. Read the comment docs.

@adamwathan
Copy link
Member Author

Gonna plow ahead with new name, and rename flex-no-wrap to flex-nowrap as well.

@adamwathan adamwathan closed this Oct 27, 2020
@adamwathan adamwathan deleted the revert-whitespace-change branch May 15, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants