Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sub and super vertical align values #2910

Closed

Conversation

TCatinaud
Copy link
Contributor

@TCatinaud TCatinaud commented Nov 26, 2020

Hi,
I would add .align-sub and .align-super classes.

Udpate verticalAlign.js

'.align-sub': { 'vertical-align': 'sub' },
'.align-super': { 'vertical-align': 'super' },

@TCatinaud TCatinaud changed the title Add sub and super vertical align values Draft:Add sub and super vertical align values Nov 26, 2020
@TCatinaud TCatinaud marked this pull request as draft November 26, 2020 10:31
@TCatinaud TCatinaud changed the title Draft:Add sub and super vertical align values Add sub and super vertical align values Nov 26, 2020
@codecov-io
Copy link

codecov-io commented Nov 26, 2020

Codecov Report

Merging #2910 (4a0c2b6) into master (3ea5e18) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2910   +/-   ##
=======================================
  Coverage   93.20%   93.20%           
=======================================
  Files         177      177           
  Lines        1795     1795           
  Branches      317      317           
=======================================
  Hits         1673     1673           
  Misses        105      105           
  Partials       17       17           
Impacted Files Coverage Δ
src/plugins/verticalAlign.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ea5e18...4a0c2b6. Read the comment docs.

@TCatinaud TCatinaud marked this pull request as ready for review November 26, 2020 11:05
@SimonJnsson
Copy link

Would like to see this merged aswell

@adamwathan
Copy link
Member

Hey thanks! I've reworked this as #5486 due to merge conflicts but have included you as a co-author on the commit to ensure you get credit ❤️

@adamwathan adamwathan closed this Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants