Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add border-hidden #3806

Closed
wants to merge 2 commits into from
Closed

add border-hidden #3806

wants to merge 2 commits into from

Conversation

kwaa
Copy link
Contributor

@kwaa kwaa commented Mar 22, 2021

implementing #1558, add border-hidden in borderStyle.js.

'.border-hidden': {
  'border-style': 'hidden',
},

MDN

@codecov-io
Copy link

codecov-io commented Mar 22, 2021

Codecov Report

Merging #3806 (e81e0ec) into master (e227320) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3806   +/-   ##
=======================================
  Coverage   93.34%   93.34%           
=======================================
  Files         178      178           
  Lines        1849     1849           
  Branches      332      332           
=======================================
  Hits         1726     1726           
  Misses        105      105           
  Partials       18       18           
Impacted Files Coverage Δ
src/plugins/borderStyle.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e227320...e81e0ec. Read the comment docs.

@samarmohan
Copy link

fix the conflicts first

@Raj-k-Jha
Copy link

'.border-hidden': {
'border-style': 'hidden',
},

@adamwathan
Copy link
Member

Reworked this here due to merge conflicts, but added as co-author so still get credit 👍🏻

#5485

Thanks!

@adamwathan adamwathan closed this Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants