Integrations setup #4354
Merged
Integrations setup #4354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4354 +/- ##
==========================================
- Coverage 71.85% 71.84% -0.02%
==========================================
Files 220 220
Lines 4769 4806 +37
Branches 790 805 +15
==========================================
+ Hits 3427 3453 +26
- Misses 1262 1267 +5
- Partials 80 86 +6
Continue to review full report at Codecov.
|
RobinMalfait
force-pushed
the
integrations-setup
branch
7 times, most recently
from
0c2fffd to
cb1cc69
Compare
The default `npm test` script will ignore all the tests in the `integrations` folder.
This script will run `npm install` in every integration, and in the integrations folder itself (to setup Jest for example).
RobinMalfait
force-pushed
the
integrations-setup
branch
2 times, most recently
from
8efde3f to
b6638d5
Compare
RobinMalfait
force-pushed
the
integrations-setup
branch
from
b6638d5 to
1b5f226
Compare
We will wait for the correct stdout/stderr output, once we know that we can request the fresh css, we will fetch it and make assertions accordingly. Port is currently hardcoded, maybe we should use a packaage to ensure that we use a free port.
RobinMalfait
force-pushed
the
integrations-setup
branch
from
1b5f226 to
74bbd8c
Compare
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrations tested: