-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui/users: create user dialog #1536
Conversation
A couple of initial thoughts:
|
Co-authored-by: Nathaniel Cook <[email protected]>
Co-authored-by: Nathaniel Cook <[email protected]>
Co-authored-by: Nathaniel Cook <[email protected]>
Co-authored-by: Nathaniel Cook <[email protected]>
Co-authored-by: Nathaniel Cook <[email protected]>
Co-authored-by: Nathaniel Cook <[email protected]>
…DB and pass it this, so we don't initialize two
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but functionally I'm seeing field errors for username show up under the display name field instead
Steps to reproduce? I'm not seeing that @Forfold |
Co-authored-by: Nathaniel Caza <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
make check
to catch common errors. Fixed any that came up.Description:
Currently, goalert admins can only create users for basic auth via the CLI. This PR brings that functionality into the UI.
Part of #1247
Screenshots:

Describe any introduced user-facing changes:
Admins will have a create user fab on the users list page
Describe any introduced API changes:
Additional Info: