Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: disable old graphql endpoint by default #1584

Merged
merged 9 commits into from
May 26, 2021
Merged

Conversation

mastercactapus
Copy link
Member

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Defaults the /v1/graphql endpoint to be disabled (returning a 404) and decouples assignment.RawTarget from the old code.

Forfold
Forfold previously approved these changes May 25, 2021
Forfold
Forfold previously approved these changes May 25, 2021
Copy link
Contributor

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2021-05-25 at 2 09 20 PM

NIT: should switch to use

function formatHeading(s = ''): string {
  return startCase(s)
    .replace(/\bTwo Way\b/, 'Two-Way')
    .replace('Enable V 1 Graph QL', 'Enable V1 GraphQL')
    .replace('Git Hub', 'GitHub')
    .replace(/R Ls\b/, 'RLs') // fix usages of `URLs`
}

EDIT: we'll fix this later

dctalbot
dctalbot previously approved these changes May 25, 2021
dctalbot
dctalbot previously approved these changes May 26, 2021
@mastercactapus mastercactapus merged commit d6d00b0 into master May 26, 2021
@mastercactapus mastercactapus deleted the disable-v1-graphql branch May 26, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants