Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrationkey: add no rows check #1640

Merged
merged 5 commits into from
Jul 13, 2021
Merged

integrationkey: add no rows check #1640

merged 5 commits into from
Jul 13, 2021

Conversation

dctalbot
Copy link
Contributor

@dctalbot dctalbot commented Jun 21, 2021 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Fixes #1709

To validate backend:

  1. use GraphQL explorer to query for an integration key with an ID that doesn't exist
  2. Should now get null instead of error

To validate UI:

  1. Open two tabs for a particular services' integration keys
  2. open a delete dialog for the same key in both
  3. Confirm in one
  4. Observe "No longer exists" message in dialog

mastercactapus
mastercactapus previously approved these changes Jun 21, 2021
View reviewed changes
@Forfold Forfold self-requested a review July 7, 2021 18:43
@dctalbot dctalbot requested a review from mastercactapus July 7, 2021 19:02
Forfold
Forfold approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally test and walked through code with @pnengchu, lgtu!

@mastercactapus mastercactapus merged commit f80cc2b into master Jul 13, 2021
@mastercactapus mastercactapus deleted the fix-int-key branch July 13, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@Forfold Forfold Forfold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

integrationkey: unexpected error returned for non-existent key in GraphQL
3 participants
@dctalbot @mastercactapus @Forfold