notification: slack status updates #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…goalert into slack-status-updates
mastercactapus
requested changes
Jul 28, 2021
Co-authored-by: Nathaniel Caza <[email protected]>
mastercactapus
previously approved these changes
Jul 29, 2021
dctalbot
suggested changes
Jul 30, 2021
|
Is there something we can say instead of just "Notified."? I have a feeling that this will be a confusing message to many users since it doesn't refer to why they are being notified within the message. |
Co-authored-by: David Talbot <[email protected]>
mastercactapus
requested changes
Aug 4, 2021
dctalbot
reviewed
Aug 4, 2021
Co-authored-by: David Talbot <[email protected]>
mastercactapus
requested changes
Aug 5, 2021
|
Do not merge before #1833. Since that PR refactors some bits that help in avoiding any circular imports in this PR. |
dctalbot
suggested changes
Aug 12, 2021
dctalbot
approved these changes
Aug 12, 2021
mastercactapus
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
This PR adds the ability to receive status updates in slack for alerts.
All updates are currently as in-thread replies, with the exception of escalations being broadcasted to the channel if it is the second notification being sent out to that channel.
This PR also adjusts the rate limits so that only types like sms, voice and email follow the specified rate limits and status update specific rate limits. Slack will not be based off of these limits, to ensure a quick end user experience.
Screenshots:
