Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/schedules: display override events on schedule calendar #1901

Merged
merged 29 commits into from
Sep 29, 2021

Conversation

spencerpauly
Copy link
Contributor

@spencerpauly spencerpauly commented Sep 15, 2021

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Currently, the calendar only shows the resulting shifts from an override. This PR adds an override item to the calendar that shows the details of the override as-well. This lets you edit these details straight from the calendar. You can change the details of the override such as who is affected & for what duration. You can also remove overrides straight from the calendar.

Screenshots:

Image of new override event on calendar.
Screen Shot 2021-09-27 at 3 44 13 PM

Tooltip when calendar item is selected:
Screen Shot 2021-09-27 at 3 43 56 PM

  • The pencil icon takes you to the edit override dialog
  • The trash can takes you to the delete override dialog

Describe any introduced user-facing changes:
Users will now be able to see overrides on the schedule calendar, and perform edit and delete operations for current/future overrides via the tooltip.

@spencerpauly spencerpauly changed the title Add override to calendar ui/schedules: Add override to calendar Sep 15, 2021
arurao and others added 4 commits September 23, 2021 14:59
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
arurao and others added 12 commits September 23, 2021 15:10
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@spencerpauly spencerpauly marked this pull request as ready for review September 27, 2021 20:00
@dctalbot dctalbot changed the title ui/schedules: Add override to calendar ui/schedules: display override events on schedule calendar Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants