Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/temporary schedules: design enhancements #1912

Merged
merged 42 commits into from
Sep 28, 2021
Merged

ui/temporary schedules: design enhancements #1912

merged 42 commits into from
Sep 28, 2021

Conversation

Forfold
Copy link
Contributor

@Forfold Forfold commented Sep 20, 2021 •
edited
Loading

Description:
Updates the dialog for Temporary Schedules per new design decisions with the aim to improve the general user experience when creating or editing a temporary schedule.

Describe any introduced user-facing changes:

  • Form Fields altered to use variant='outline' (can revert if undesirable)
  • Dialog is no longer fullscreen
  • Stepper is no longer used. Start and End fields have been added above the fields to add a shift
  • Default start times are now the next Monday through Friday
  • Coverage warning moved to the top of the shift list
    • This change ensures the warning is seen right away on mobile or desktop.
  • Retains shift duration when adding shifts
  • Adds a notice to the top of each day if it is out of the set start/end range

Describe any introduced API changes:

  • "Retry" vs. "Submit" text for LoadingButton is now determined based off a true attempt count, rather than the number of errors sent from props.

Out of Scope:

  • Fix transitions
  • Clicking on "No Coverage" warning opens Add Shift panel, sets start time to beginning of the gap in coverage

Screenshots:
Screen Shot 2021-09-20 at 12 49 21 PM
Screen Shot 2021-09-20 at 12 49 31 PM
Screen Shot 2021-09-23 at 10 22 41 AM

@target target deleted a comment from github-actions bot Sep 21, 2021
@target target deleted a comment from github-actions bot Sep 21, 2021
@spencerpauly spencerpauly self-requested a review September 22, 2021 18:45
@pnengchu pnengchu requested a review from dctalbot September 22, 2021 18:52
dctalbot
dctalbot previously approved these changes Sep 27, 2021
View reviewed changes
@Forfold
Copy link
Contributor Author

Forfold commented Sep 27, 2021

Working on fixing some tests atm

dctalbot
dctalbot previously approved these changes Sep 27, 2021
View reviewed changes
dctalbot
dctalbot previously approved these changes Sep 27, 2021
View reviewed changes
spencerpauly
spencerpauly previously approved these changes Sep 28, 2021
View reviewed changes
dctalbot
dctalbot suggested changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing an issue when editing and "fast-forwarding" the temp sched start time. I suggest disabling the start/end fields for now.

Screen.Recording.2021-09-28.at.1.21.00.PM.mov

@Forfold Forfold merged commit af1696e into master Sep 28, 2021
@Forfold Forfold deleted the temp-sched-ux branch September 28, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dctalbot dctalbot dctalbot approved these changes

@spencerpauly spencerpauly spencerpauly approved these changes

Assignees
No one assigned
Labels
temporary schedules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Forfold @dctalbot @spencerpauly