slack: add hints and update manifest #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dctalbot
suggested changes
Nov 10, 2021
dctalbot
previously approved these changes
Nov 10, 2021
Co-authored-by: David Talbot <[email protected]>
dctalbot
previously approved these changes
Nov 10, 2021
pnengchu
previously approved these changes
Nov 10, 2021
mastercactapus
dismissed stale reviews from pnengchu and dctalbot
via
1e5471b
dctalbot
approved these changes
Nov 10, 2021
pnengchu
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a callback URL hint in Slack config, adds missing scope to the app manifest, and renames button to "App Manifest" rather than "Create New App" now that Slack allows editing/updating the manifest for existing apps.