Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/services: Alert metrics dashboard #2085

Merged
merged 63 commits into from
Jan 18, 2022
Merged

ui/services: Alert metrics dashboard #2085

merged 63 commits into from
Jan 18, 2022

Conversation

dctalbot
Copy link
Contributor

@dctalbot dctalbot commented Jan 6, 2022 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR is the first iteration of the Alert Metrics dashboard feature. It provides:

  • a new Service Details quick link page that displays metrics for a given service
  • a graph of alert counts, grouped by date in the user's system timezone (shows 100 alerts max).
  • a table of alert details
  • a date range filter to view the past 1, 2, 3, or 4 weeks of alerts.
  • a CSV export button

Screenshots:
Screen Shot 2022-01-10 at 12 12 15 PM

@dctalbot dctalbot marked this pull request as draft January 6, 2022 19:50
@KatieMSB KatieMSB changed the title Alert metrics dashboard ui/services: Alert metrics dashboard Jan 10, 2022
@KatieMSB KatieMSB marked this pull request as ready for review January 10, 2022 18:15
@Forfold Forfold self-requested a review January 13, 2022 20:15
@dctalbot dctalbot requested a review from arurao January 14, 2022 16:00
Forfold
Forfold requested changes Jan 17, 2022
View reviewed changes
@dctalbot dctalbot requested a review from Forfold January 18, 2022 17:22
Forfold
Forfold approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Loads well with a clean console 🎉 Functionally tested exporting a CSV of alerts as well.

arurao
arurao approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@arurao arurao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Functionally validated. Nice work!

@dctalbot dctalbot merged commit a2b8255 into master Jan 18, 2022
@dctalbot dctalbot deleted the alert-metrics branch January 18, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Forfold Forfold Forfold approved these changes

@arurao arurao arurao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dctalbot @Forfold @arurao @KatieMSB