-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: add dark mode toggle to navbar #2174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next up should include:
- Handling error screens (e.g. 404 sad face)
- Handling secondary dialog buttons (e.g. cancel, close)
Good callout on the error screens- that's a good addition to add to our draft issue |
@dctalbot Seems like something that got missed but caught in review. Hard to see, but hopefully an easy fix: Secondary buttons aren't as bad, but that also looks like it's not intentional: I think the secondary is supposed to have blue text matching the other button (I could be wrong) We should fix things like that before merging, anyone with a dark system theme will get the dark mode by default so we should make sure it's finished, at least the simple stuff. @Forfold Adjusting color for form dialogs (cancel/back buttons only) and error components shouldn't require major changes, correct? |
The blue text is primary @mastercactapus, so probably not the best option for the cancel buttons. We have secondary as Edit: It looks like material.io uses |
@Forfold Yeah, that's what I noticed in the MUI dialog examples: Since that's what we do in light mode I assumed dark mode would work the same, in any case, my concern is just the readability. Whatever you think is best |
Well we don't actually have a primary or secondary color for light mode. We just have grey. So I was assuming that it should be secondary, but yeah since material.io (https://material.io/components/dialogs#anatomy) shows both buttons using primary too we can go with that |
@Forfold sounds good I took a look locally, much better. What about the components in As before, whatever you think is best, just looking for some better contrast |
Yep, working through the error component right now |
Closes #1694
Introduces a button group for dark mode to the user profile, defaulting to the system preference, saving to local storage. The primary grey color for light mode has been retained, with MUI defaults being leveraged for dark mode.
Component changes to accommodate dark mode:
ThemePicker
component to render option buttons from profilethemeConfig.ts
file containing aThemeContext
, and aThemeProvider
implementing the theme config, removing the old config withinmui.ts
ScheduleCalendar
, now that theme has movedAlertListFilter
icon to use proper contrast color when in dark modesecondary
)FlatList
FlatList
list item subheader background color always being white (now transparent to match bg, no difference to light mode)OtherActions
inRotationUserList
if the user is activeSlack
andSlackBW
iconsOut of Scope:
FlatList
highlighted items, orSetFavoriteButton
's heart color to better fit both light & dark mode palettessecondary
colorsScreenshots: