-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine: new module for alert metrics #2177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastercactapus
previously approved these changes
Mar 7, 2022
mastercactapus
previously approved these changes
Mar 7, 2022
mastercactapus
approved these changes
Mar 8, 2022
KatieMSB
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make check
to catch common errors. Fixed any that came up.Description:
This PR introduces a new engine module for creating and populating a new
alert_metrics
table. It prioritizes newly-closed alerts, but will eventually process all remaining closed alerts.Which issue(s) this PR fixes:
Fixes #2121
How to review:
make regendb
engine/metricsmanager/update.go
make start
engine_processing_versions.state
column is populatedalert_metrics
table is populatedAdditional Info:
id
column in order to be compatible with the switchover tool.