Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: use esbuild for app.js #2314

Merged
merged 8 commits into from
Apr 20, 2022
Merged

dev: use esbuild for app.js #2314

merged 8 commits into from
Apr 20, 2022

Conversation

mastercactapus
Copy link
Member

@mastercactapus mastercactapus commented Apr 19, 2022

Description:
Replaces webpack with esbuild for building app.js.

  • faster build
  • simpler build & dev
  • fixes localdev cache issues

Review:

  • Check with HTTP_PREFIX set
  • prod and non-prod mode (& /w cypress)
  • changes should result in page refresh (may need hard refresh once/first if you were previously affected by cache bug)
  • validate js files container GOALERT_VERSION banner

Out of Scope:
Cypress still uses a webpack plugin to build the test bundle and will be migrated separately.

@mastercactapus mastercactapus marked this pull request as draft April 19, 2022 18:38
@mastercactapus mastercactapus marked this pull request as ready for review April 19, 2022 18:55
@Forfold Forfold self-requested a review April 19, 2022 21:18
@mastercactapus mastercactapus merged commit adba308 into master Apr 20, 2022
@mastercactapus mastercactapus deleted the app-esbuild branch April 20, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants