Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/services/alertmetrics: fix alert metrics graph styles #2323

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

dctalbot
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This styles the alert metrics graph using our MUI theme and MUI Paper, Typography elements for the graph's tooltip.

Which issue(s) this PR fixes:
Fixes #2310

Screenshots:

Screen.Recording.2022-04-21.at.11.25.01.AM.mov

KatieMSB
KatieMSB previously approved these changes Apr 21, 2022
mastercactapus
mastercactapus previously approved these changes Apr 25, 2022
@dctalbot dctalbot dismissed stale reviews from mastercactapus and KatieMSB via 4fee8e5 April 25, 2022 16:35
@dctalbot dctalbot merged commit d082997 into master Apr 25, 2022
@dctalbot dctalbot deleted the alert-metrics-graph-styles branch April 25, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alert metrics bar chart date is hidden in dark mode
3 participants