ui: allow choosing theme color with native input #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # yarn.lock
# Conflicts: # web/src/app/theme/themeConfig.tsx # web/src/package.json # yarn.lock
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mastercactapus
previously approved these changes
May 17, 2022
mastercactapus
previously approved these changes
May 20, 2022
mastercactapus
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a color picker to the Theme Mode (now renamed to Appearance) ButtonGroup in the Settings Popover, so users can choose whichever color they prefer as their source for GoAlert's palette. The color's hex # is saved in local storage and works for both light and dark modes.
The main primary theme has been changed to leverage
@material/material-color-utilitiesfor calculating the proper hex colors. This is the backend for the tool we used as a team to pick the hard-coded color values currently in master.Screenshots: